[PATCH] D125084: [test, x86] Fix spurious x86-target-features.c failure

Phoebe Wang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 17 06:18:10 PDT 2022


pengfei added inline comments.


================
Comment at: clang/test/Driver/x86-target-features.c:173
 // LVIHARDENING: "-target-feature" "+lvi-load-hardening" "-target-feature" "+lvi-cfi"
-// NO-LVIHARDENING-NOT: lvi
+// NO-LVIHARDENING-NOT: "-target-feature" "+lvi
 
----------------
How about just `// NO-LVIHARDENING-NOT: "+lvi-`? It should be distinct enough. We intentionally use less combination on a negative test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125084/new/

https://reviews.llvm.org/D125084



More information about the cfe-commits mailing list