[PATCH] D125711: [concepts] Implement dcl.decl.general p4: No constraints on non-template funcs
Erich Keane via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue May 17 05:51:03 PDT 2022
erichkeane marked an inline comment as done.
erichkeane added a comment.
In D125711#3517065 <https://reviews.llvm.org/D125711#3517065>, @royjacobson wrote:
> Code and added/modified tests LGTM!
>
> Do you think we should add a release note, given that it could break existing code? Its seems a bit unlikely, but the amount of broken tests have made me a bit worried.
> Also, maybe mention the github issue (https://github.com/llvm/llvm-project/issues/51173) in the commit message.
Thanks for the review! I absolutely need a release note, I'll add one before committing.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125711/new/
https://reviews.llvm.org/D125711
More information about the cfe-commits
mailing list