[PATCH] D101471: [clang-tidy] Add proper emplace checks to modernize-use-emplace

Jakub Kuderski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 16 10:59:57 PDT 2022


kuhar resigned from this revision.
kuhar added inline comments.
Herald added a subscriber: carlosgalvezp.
Herald added a project: All.


================
Comment at: clang-tools-extra/clang-tidy/modernize/UseEmplaceCheck.cpp:44
+  // FullNameTrimmed matches any of the given Names.
+  const StringRef FullNameTrimmedRef = StringRef(FullNameTrimmed);
+  for (const StringRef Pattern : Names) {
----------------
nit: `StringRef(` seems unnecessary on the rhs of `=`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101471/new/

https://reviews.llvm.org/D101471



More information about the cfe-commits mailing list