[clang] 0b69b83 - [Driver] Change "zlib not installed" diagnostic to "zlib not enabled"

Fangrui Song via cfe-commits cfe-commits at lists.llvm.org
Mon May 16 10:42:50 PDT 2022


Author: Fangrui Song
Date: 2022-05-16T10:42:44-07:00
New Revision: 0b69b8384d9b92898ec29f78a2364bec2277e516

URL: https://github.com/llvm/llvm-project/commit/0b69b8384d9b92898ec29f78a2364bec2277e516
DIFF: https://github.com/llvm/llvm-project/commit/0b69b8384d9b92898ec29f78a2364bec2277e516.diff

LOG: [Driver] Change "zlib not installed" diagnostic to "zlib not enabled"

The former is a bit misleading and a user may try installing zlib which
will not help.

Added: 
    

Modified: 
    clang/include/clang/Basic/DiagnosticDriverKinds.td
    clang/test/Driver/nozlibcompress.c

Removed: 
    


################################################################################
diff  --git a/clang/include/clang/Basic/DiagnosticDriverKinds.td b/clang/include/clang/Basic/DiagnosticDriverKinds.td
index e58cfe6c4c56..7961b006a9a0 100644
--- a/clang/include/clang/Basic/DiagnosticDriverKinds.td
+++ b/clang/include/clang/Basic/DiagnosticDriverKinds.td
@@ -412,7 +412,7 @@ def warn_missing_sysroot : Warning<"no such sysroot directory: '%0'">,
   InGroup<DiagGroup<"missing-sysroot">>;
 def warn_incompatible_sysroot : Warning<"using sysroot for '%0' but targeting '%1'">,
   InGroup<DiagGroup<"incompatible-sysroot">>;
-def warn_debug_compression_unavailable : Warning<"cannot compress debug sections (zlib not installed)">,
+def warn_debug_compression_unavailable : Warning<"cannot compress debug sections (zlib not enabled)">,
   InGroup<DiagGroup<"debug-compression-unavailable">>;
 def warn_drv_disabling_vptr_no_rtti_default : Warning<
   "implicitly disabling vptr sanitizer because rtti wasn't enabled">,

diff  --git a/clang/test/Driver/nozlibcompress.c b/clang/test/Driver/nozlibcompress.c
index 9a704e70bc17..45935f595285 100644
--- a/clang/test/Driver/nozlibcompress.c
+++ b/clang/test/Driver/nozlibcompress.c
@@ -3,5 +3,5 @@
 // RUN: %clang -### -fintegrated-as -gz -c %s 2>&1 | FileCheck %s -check-prefix CHECK-WARN
 // RUN: %clang -### -fintegrated-as -gz=none -c %s 2>&1 | FileCheck -allow-empty -check-prefix CHECK-NOWARN %s
 
-// CHECK-WARN: warning: cannot compress debug sections (zlib not installed)
-// CHECK-NOWARN-NOT: warning: cannot compress debug sections (zlib not installed)
+// CHECK-WARN: warning: cannot compress debug sections (zlib not enabled)
+// CHECK-NOWARN-NOT: warning: cannot compress debug sections (zlib not enabled)


        


More information about the cfe-commits mailing list