[PATCH] D125026: [clang-tidy][NFC] Reimplement SimplifyBooleanExpr with RecursiveASTVisitors

Mon May 16 05:32:03 PDT 2022

njames93 added a comment.

So those times were a little unfair as now we don't use ParentMapContext, however the cost of building that is included in the running time for the check.
In a use case where you have other enabled checks with do make use of that, the cost for building would be moved to other checks.
In order to level the playing field slightly, I've build the ParentMapContext ahead of time in both implementations for a fairer comparison in typical use cases.
This yields 0.20s for the original impl and 0.04s for this implementation.
Not quite as large a gap but still a 5x improvement.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125026/new/

https://reviews.llvm.org/D125026