[PATCH] D94727: [clangd] Retire some flags for uncontroversial, stable features.

[Sam McCall via Phabricator via cfe-commits]

sammccall marked an inline comment as done.
sammccall added inline comments.


================
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:762
     Opts.ResourceDir = ResourceDir;
-  Opts.BuildDynamicSymbolIndex = EnableIndex;
+  Opts.BuildDynamicSymbolIndex = true;
   Opts.CollectMainFileRefs = CollectMainFileRefs;
----------------
ivanmurashko wrote:
> @sammccall The option is always true, do we need it as an option?
It's false in tests, except when we're testing the index specifically.
On balance I think this is a good think because it allows us to reason about a simpler system when designing/debugging tests. In particular we don't have to worry about the AST-paths in tests "cheating" by looking at the index.

Seems sensible to make the struct default true and set it to false explicitly in optsForTest, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94727/new/

https://reviews.llvm.org/D94727