[PATCH] D124751: [HLSL] Support -E option for HLSL.

Xiang Li via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat May 14 06:17:54 PDT 2022


python3kgae added a comment.

In D124751#3513283 <https://reviews.llvm.org/D124751#3513283>, @MaskRay wrote:

> Is there a specification or reference implementation stating that -E is used?
>
>> Option<["--", "/", "-"], "E",
>
> Do you need the prefix `--`? You may define something like `CLFlag`. I have missed previous patches, but if `/` options are not necessary, removing them will be the best to avoid collision with filenames starting with `/`.

Unfortunately, '/' is necessary. dxc allow both '-' and '/' like 'CLFlag'.
Remove '/' means existing customers may need to change their command line to compile hlsl.
And add '--' feels not hurt anyone, that's why I choose to add '--' to work-around the conflict.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124751/new/

https://reviews.llvm.org/D124751



More information about the cfe-commits mailing list