[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 13 23:21:54 PDT 2022


dexonsmith accepted this revision.
dexonsmith added a comment.

LGTM, thanks! One comment online below.



================
Comment at: clang/include/clang/Config/config.h.cmake:19
 #cmakedefine CLANG_DEFAULT_STD_C LangStandard::lang_${CLANG_DEFAULT_STD_C}
+// Always #define something so that missing the config.h #include at use sites
+// becomes a compile error.
----------------
I just noticed that the other comments in this file are C-style. Probably the new ones should be too. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124974/new/

https://reviews.llvm.org/D124974



More information about the cfe-commits mailing list