[PATCH] D125195: [asan][ARMCXXABI] Added missing asan poison array cookie hooks.

[Roy Sundahl via Phabricator via cfe-commits]

rsundahl added inline comments.


================
Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2191
         CGM.CreateRuntimeFunction(FTy, "__asan_poison_cxx_array_cookie");
+//  CGF.Builder.CreateCall(F, NumElementsPtr.getRawPointer(CGF));
     CGF.Builder.CreateCall(F, NumElementsPtr.getPointer());
----------------
NumElementsPtr.getRawPointer(CGF) had to be changed to CGF.Builder.CreateCall(F, NumElementsPtr.getPointer() but likely will have to be switched back when it appears downstream.


================
Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2223
       CGM.CreateRuntimeFunction(FTy, "__asan_load_cxx_array_cookie");
+//return CGF.Builder.CreateCall(F, numElementsPtr.getRawPointer(CGF));
   return CGF.Builder.CreateCall(F, numElementsPtr.getPointer());
----------------
NumElementsPtr.getRawPointer(CGF) had to be changed to CGF.Builder.CreateCall(F, NumElementsPtr.getPointer() but likely will have to be switched back when it appears downstream.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125195/new/

https://reviews.llvm.org/D125195