[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

Adrian Prantl via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 13 10:50:44 PDT 2022

Previous message: [PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.
Next message: [clang] 0dbaef6 - [OpenMP] Fix mangling for linear modifiers with variable stride
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

aprantl added a comment.

I think this mostly looks good. I left comment about the test inline.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123534/new/

https://reviews.llvm.org/D123534

Previous message: [PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.
Next message: [clang] 0dbaef6 - [OpenMP] Fix mangling for linear modifiers with variable stride
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the cfe-commits mailing list