[PATCH] D125429: Comment parsing: Allow inline commands to have 0 or more than 1 argument

[Nico Weber via Phabricator via cfe-commits]

thakis added a comment.

Hello, this broke building on mac:

- http://45.33.8.238/macm1/35247/step_4.txtp
- https://green.lab.llvm.org/green/job/clang-stage1-RA/

Please take a look, and revert for now if it takes a while to fix.

(Here's the error:

  In file included from ../../clang/lib/AST/CommentParser.cpp:9:
  In file included from ../../clang/include/clang/AST/CommentParser.h:16:
  In file included from ../../clang/include/clang/AST/Comment.h:17:
  In file included from ../../clang/include/clang/AST/DeclObjC.h:16:
  In file included from ../../clang/include/clang/AST/Decl.h:19:
  In file included from ../../clang/include/clang/AST/DeclBase.h:18:
  In file included from ../../clang/include/clang/AST/DeclarationName.h:16:
  In file included from ../../clang/include/clang/AST/Type.h:21:
  In file included from ../../clang/include/clang/AST/NestedNameSpecifier.h:18:
  ../../clang/include/clang/Basic/Diagnostic.h:1353:8: error: use of overloaded operator '<<' is ambiguous (with operand types 'const clang::StreamingDiagnostic' and 'typename remove_reference<unsigned long &>::type' (aka 'unsigned long'))
      DB << std::move(V);
      ~~ ^  ~~~~~~~~~~~~
  ../../clang/lib/AST/CommentParser.cpp:417:57: note: in instantiation of function template specialization 'clang::DiagnosticBuilder::operator<<<unsigned long, void>' requested here
          << CommandTok.is(tok::at_command) << Info->Name << Args.size()
                                                          ^
  ../../clang/include/clang/Basic/Diagnostic.h:1400:35: note: candidate function
  inline const StreamingDiagnostic &operator<<(const StreamingDiagnostic &DB,
                                    ^
  ../../clang/include/clang/Basic/Diagnostic.h:1406:35: note: candidate function
  inline const StreamingDiagnostic &operator<<(const StreamingDiagnostic &DB,
                                    ^
  ../../clang/include/clang/Basic/Diagnostic.h:1422:35: note: candidate function
  inline const StreamingDiagnostic &operator<<(const StreamingDiagnostic &DB,
                                    ^
  ../../clang/include/clang/Basic/Diagnostic.h:1428:35: note: candidate function
  inline const StreamingDiagnostic &operator<<(const StreamingDiagnostic &DB,
                                    ^
  ../../clang/include/clang/Basic/Diagnostic.h:1353:8: note: built-in candidate operator<<(int, unsigned long)
      DB << std::move(V);
         ^
  ../../clang/include/clang/Basic/Diagnostic.h:1353:8: note: built-in candidate operator<<(int, int)
  ../../clang/include/clang/Basic/Diagnostic.h:1353:8: note: built-in candidate operator<<(int, long)
  ../../clang/include/clang/Basic/Diagnostic.h:1353:8: note: built-in candidate operator<<(int, long long)
  ../../clang/include/clang/Basic/Diagnostic.h:1353:8: note: built-in candidate operator<<(int, __int128)
  ../../clang/include/clang/Basic/Diagnostic.h:1353:8: note: built-in candidate operator<<(int, unsigned int)
  ../../clang/include/clang/Basic/Diagnostic.h:1353:8: note: built-in candidate operator<<(int, unsigned long long)
  ../../clang/include/clang/Basic/Diagnostic.h:1353:8: note: built-in candidate operator<<(int, unsigned __int128)
  ../../clang/include/clang/Basic/Diagnostic.h:1353:8: note: built-in candidate operator<<(long, unsigned long)
  ../../clang/include/clang/Basic/Diagnostic.h:1353:8: note: built-in candidate operator<<(long long, unsigned long)
  ../../clang/include/clang/Basic/Diagnostic.h:1353:8: note: built-in candidate operator<<(__int128, unsigned long)
  ../../clang/include/clang/Basic/Diagnostic.h:1353:8: note: built-in candidate operator<<(unsigned int, unsigned long)
  ../../clang/include/clang/Basic/Diagnostic.h:1353:8: note: built-in candidate operator<<(unsigned long, unsigned long)
  ../../clang/include/clang/Basic/Diagnostic.h:1353:8: note: built-in candidate operator<<(unsigned long long, unsigned long)
  ../../clang/include/clang/Basic/Diagnostic.h:1353:8: note: built-in candidate operator<<(unsigned __int128, unsigned long)

)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125429/new/

https://reviews.llvm.org/D125429