[PATCH] D122895: [C89/C2x] Improve diagnostics around strict prototypes in C

Fri May 13 05:33:22 PDT 2022

aaron.ballman added a comment.

In D122895#3511312 <https://reviews.llvm.org/D122895#3511312>, @aaron.ballman wrote:

> However, I think the blocks behavior is a bug based on this: https://github.com/llvm/llvm-project/blob/main/clang/lib/Sema/SemaType.cpp#L728 and I'd be more than happy to fix that, as I'm not checking that condition here: https://github.com/llvm/llvm-project/blob/main/clang/lib/Sema/SemaType.cpp#L5579 which seems like a pretty obvious thing to be checking for before warning about not having a strict prototype.

I fixed this false positive bug in 4be105c98a9c7e083cd878ee1751e11160b97b4a <https://reviews.llvm.org/rG4be105c98a9c7e083cd878ee1751e11160b97b4a>, so blocks (and OpenCL) behavior should now be improved.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122895/new/

https://reviews.llvm.org/D122895