[PATCH] D125383: [ASTMatchers][clang-tidy][NFC] Hoist 'forEachTemplateArgument' matcher into the core library

Fri May 13 03:48:09 PDT 2022

aaron.ballman added a comment.

In D125383#3510906 <https://reviews.llvm.org/D125383#3510906>, @whisperity wrote:

> In D125383#3509084 <https://reviews.llvm.org/D125383#3509084>, @aaron.ballman wrote:
>
>> Then I think the only thing missing here are updates to https://github.com/llvm/llvm-project/blob/main/clang/lib/ASTMatchers/Dynamic/Registry.cpp.
>
> Could you please check if I did it the right way? I did not know about this file, and I am still not exactly sure about its purpose.

Yup, you did it correct! This is the magic that allows clang-query to work -- it sets up the dynamic mapping of C++ matchers, so if you forget to add something to that list, it'll be available to folks in C++ but not in clang-query.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125383/new/

https://reviews.llvm.org/D125383