[PATCH] D125529: Revert MSVC compatibility feature that breaks conformant code

Fred Tingaud via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 13 02:45:42 PDT 2022


frederic-tingaud-sonarsource created this revision.
frederic-tingaud-sonarsource added reviewers: rnk, thakis.
Herald added a reviewer: shafik.
Herald added a project: All.
frederic-tingaud-sonarsource requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

The fix at https://reviews.llvm.org/D124613 mimics MSVC behavior with friend declarations, but it does break some C++ conformant code that was built with -fms-compatibility. This fix reverts it to avoid causing more problems.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D125529

Files:
  clang/lib/Sema/SemaDecl.cpp
  clang/test/SemaCXX/ms-friend-function-decl.cpp
  clang/unittests/AST/ASTImporterTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D125529.429180.patch
Type: text/x-patch
Size: 4193 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220513/b6db73b7/attachment.bin>


More information about the cfe-commits mailing list