[PATCH] D122734: [CUDA][HIP] Fix mangling number for local struct

[Mikael Holmén via Phabricator via cfe-commits]

uabelho added a comment.

In D122734#3509187 <https://reviews.llvm.org/D122734#3509187>, @yaxunl wrote:

> In D122734#3509096 <https://reviews.llvm.org/D122734#3509096>, @yaxunl wrote:
>
>> In D122734#3508294 <https://reviews.llvm.org/D122734#3508294>, @uabelho wrote:
>>
>>> Hi,
>>>
>>> I noticed when compiling with gcc 9.3.0 that we get a bunch of new warnings with this patch:
>>>
>>>   [1/351] Building CXX object tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/MicrosoftCXXABI.cpp.o
>>>   ../../clang/lib/AST/MicrosoftCXXABI.cpp:57:12: warning: 'virtual unsigned int {anonymous}::MicrosoftNumberingContext::getManglingNumber(const clang::VarDecl*, unsigned int)' was hidden [-Woverloaded-virtual]
>>>      57 |   unsigned getManglingNumber(const VarDecl *VD,
>>>         |            ^~~~~~~~~~~~~~~~~
>>>   ../../clang/lib/AST/MicrosoftCXXABI.cpp:80:12: warning:   by 'virtual unsigned int {anonymous}::MSHIPNumberingContext::getManglingNumber(const clang::TagDecl*, unsigned int)' [-Woverloaded-virtual]
>>>      80 |   unsigned getManglingNumber(const TagDecl *TD,
>>>         |            ^~~~~~~~~~~~~~~~~
>
> fixed by 0f292141aadb0489231de31de966c239486e019d <https://reviews.llvm.org/rG0f292141aadb0489231de31de966c239486e019d>

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122734/new/

https://reviews.llvm.org/D122734