[PATCH] D125162: [clang-format] fix alignment w/o binpacked args
Marek Kurdej via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu May 12 23:03:46 PDT 2022
curdeius accepted this revision.
curdeius added a comment.
This revision is now accepted and ready to land.
LGTM. Tell us if you need help landing this.
Thanks a lot for your contribution!
================
Comment at: clang/lib/Format/WhitespaceManager.cpp:374-375
return false;
+ if (Changes[i].Tok->is(tok::l_brace) &&
+ Changes[i].Tok->is(BK_BracedInit))
+ return true;
----------------
cha5on wrote:
> curdeius wrote:
> > It seems that we set `BK_BracedInit` only on `l_brace`, so no need for a redundant check.
> `BK_BracedInit` also gets set on `r_brace`, assuming I'm reading `clang/lib/Format/UnwrappedLineParser.cpp` correctly. I think we need both to be true to be sure that this is the intended token.
Ok.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125162/new/
https://reviews.llvm.org/D125162
More information about the cfe-commits
mailing list