[PATCH] D125488: [Preprocessor] Make the special lexing for dependency scanning a first-class feature of the `Preprocessor` and `Lexer`

Thu May 12 16:30:05 PDT 2022

akyrtzi added a comment.

In D125488#3510297 <https://reviews.llvm.org/D125488#3510297>, @dexonsmith wrote:

> [To be clear, my question was because I don't see this patch deleting the code path that minimizes / saves-minimized sources. Can/should we delete the "minimize sources" code path?]

Oh, this is removed in the prior patch in the review stack (https://reviews.llvm.org/D125487)

> I like the direction of trying to remove FSStatCache. I think stat/content caching belongs at the VFS level so DepFS seems like a better starting point (maybe generalized a bit). Note that DepFS isn't just amortizing `stat` cost, it's also avoiding reopening / `mmap`ing / `mempcy`ing files.

That's a good point, so maybe the direction to go is to generalize the DepFS caching mechanism.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125488/new/

https://reviews.llvm.org/D125488