[PATCH] D125484: [Tooling/DependencyScanning] Rename refactorings towards transitioning dependency scanning to use pre-lexed preprocessor directive tokens
Argyrios Kyrtzidis via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu May 12 15:31:16 PDT 2022
akyrtzi marked an inline comment as done.
akyrtzi added inline comments.
================
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:120
+ clEnumValN(ScanningMode::DependencyDirectivesScan,
+ "preprocess-directives-scan",
+ "The set of dependencies is computed by preprocessing with "
----------------
jansvoboda11 wrote:
> Probably unnecessary bike-shedding, but something like `preprocess-dependency-directives` or `scan-and-preprocess-dependency-directives` would read better IMO. Up to you whether you change this.
`preprocess-dependency-directives` is indeed better, I've renamed the flag to that 👍
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125484/new/
https://reviews.llvm.org/D125484
More information about the cfe-commits
mailing list