[PATCH] D125011: [MSVC] Add support for pragma alloc_text
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu May 12 07:04:31 PDT 2022
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from some minor commenting nits that you can fix when landing. Can you also add a release note for the new pragma support?
================
Comment at: clang/include/clang/Sema/Sema.h:727
+ /// Sections used with #pragma alloc_text
+ llvm::StringMap<std::tuple<StringRef, SourceLocation>> FunctionToSectionMap;
----------------
aaron.ballman wrote:
>
Looks like this one was missed.
================
Comment at: clang/include/clang/Sema/Sema.h:10337
+ void AddSectionMSAllocText(FunctionDecl *FD);
+
----------------
aaron.ballman wrote:
> This could probably have some comments with it.
Same here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125011/new/
https://reviews.llvm.org/D125011
More information about the cfe-commits
mailing list