[PATCH] D124613: In MSVC compatibility mode, friend function declarations behave as function declarations

Fred Tingaud via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 11 10:31:09 PDT 2022


frederic-tingaud-sonarsource added a comment.

In D124613#3506740 <https://reviews.llvm.org/D124613#3506740>, @thakis wrote:

> Should we revert this, at least for now, until the investigation is complete?

I started typing my message before you sent yours so it was not a direct answer. We are working on a fork of LLVM, so if you revert the fix for the moment, it will not put us in a bad position anyway. I'll let you judge on whether the current problem can remain until my fixing PR is reviewed or whether you prefer to revert immediately and for me to make a clean PR with the corrected version afterward.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124613/new/

https://reviews.llvm.org/D124613



More information about the cfe-commits mailing list