[PATCH] D124613: In MSVC compatibility mode, friend function declarations behave as function declarations

[Nico Weber via Phabricator via cfe-commits]

thakis added a comment.

Given that:

- This is not needed for system headers
- Before the change, users had to fix their standards-noncompliant code, but with it, users have to change their previously-compiling, standards-compliant code
- The change is a no-op for C++20 and up anyways
- There's no warning implemented, so the change is kind of against the spirit of clang-cl atm
- The change can't affect a lot of code since we didn't have if for a long time (and it only broke one single thing in all of chrome), so erring on less code in clang seems better

Should we revert this, at least for now, until the investigation is complete?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124613/new/

https://reviews.llvm.org/D124613