[PATCH] D124447: [clang-tidy] Add infrastructure support for running on project-level information

Wed May 11 09:56:29 PDT 2022

whisperity added a comment.

In D124447#3506536 <https://reviews.llvm.org/D124447#3506536>, @whisperity wrote:

> In D124447#3493996 <https://reviews.llvm.org/D124447#3493996>, @whisperity wrote:
>
>> In D124447#3493446 <https://reviews.llvm.org/D124447#3493446>, @aaron.ballman wrote:
>>
>>> precommit CI is showing a fair amount of failures that I believe are related to your patch.
>>
>> I have no idea what is causing the CI issues, because all the CI issues are related to unit test libraries removing `const` from fixits and such(??) which this patch (or any in the current patch set) doesn't even touch, at all. I did run the test targets locally... it's likely that simply the rebase and the push happened against an unclean/breaking main branch...
>
> Rebase & rerun against a current `main` branch produces the issues locally for me, too. So far I have no idea what might be causing this, but I'll keep on digging. However, let's continue with discussing the general approach meanwhile. 🙂

Actually, it turned out to be easy after all! The implementation **is** backwards compatible //on the command-line// but was not for the "machine-driven" tests that are implemented as C++ code and execution scaffold. Adding the below commented change to the diff **completely** solved the failing tests for me locally (turns out none of the checks were actually running the `check()` callback!), but I cannot update a //"Revision"// that I do not own.

================
Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.h:60
+
+  MultipassProjectPhase MultipassPhase;
+  /// The directory where multi-pass project-level analysis stores its data to.
----------------
⚠ The crucial fix against the unit-test failures!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124447/new/

https://reviews.llvm.org/D124447