[PATCH] D125362: [NFC][analyzer] Transitive interestingness in BugReporter

Balázs Benics via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 11 09:46:45 PDT 2022


steakhal added a comment.

In D125362#3506545 <https://reviews.llvm.org/D125362#3506545>, @balazske wrote:

> Is it problem if `markNotInteresting` is used on a symbol that was marked interesting and has subregions?

In that case, the sub-symbols will remain still interesting.
We might need to think about this and also make `markNotInteresting()` transitive. I'm not immediately sure about the implications, but a test demonstrating the transitivity should demonstrate this as well in a slightly modified example.
The test file for this should be `clang/unittests/StaticAnalyzer/BugReportInterestingnessTest.cpp` though.

There are only two checkers using this API: stream checker and the smart ptr checker.
We should craft a real-worl-looking example pointing out the difference between the *transitive* and *direct* `markNotInteresting()` implementation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125362/new/

https://reviews.llvm.org/D125362



More information about the cfe-commits mailing list