[PATCH] D125340: [clang][NFC][AST] rename the ImportError to ASTImportError

Shivam Rajput via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 11 06:59:07 PDT 2022


phyBrackets added a comment.

In D125340#3505723 <https://reviews.llvm.org/D125340#3505723>, @martong wrote:

> What are the benefits of this renaming? I mean is there a name clash? Do we have another kind of "import" in Clang or in some of the dependent projects, don't we?

AS it suggested by @balazske in the previous patch , and I also think if we moved the ImportError into it's own header then it's better to be named as ASTImportError .


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125340/new/

https://reviews.llvm.org/D125340



More information about the cfe-commits mailing list