[PATCH] D125338: [HLSL] add -D option for dxc mode.

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from a testing suggestion.



================
Comment at: clang/test/Driver/dxc_D.hlsl:5
+// CHECK:"-D" "TEST=2"
+
----------------
Maybe we should also test that the macro is actually defined?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125338/new/

https://reviews.llvm.org/D125338