[PATCH] D123810: [Cuda] Add initial support for wrapping CUDA images in the new driver.

Joseph Huber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 10 15:46:23 PDT 2022


jhuber6 added a comment.

Thanks for the review.



================
Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:193
+  }
+  static unsigned getHashValue(const OffloadKind &Val) { return Val * 37U; }
+
----------------
tra wrote:
> Is there a particular reason for multiplying by 37? Enum values by themselves should do the job just fine. 
That's what LLVM does for the regular `DenseMapInfo<uint16_t>::getHashValue()` so I just copied it here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123810/new/

https://reviews.llvm.org/D123810



More information about the cfe-commits mailing list