[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

Mehdi AMINI via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 10 15:07:04 PDT 2022


mehdi_amini added a comment.

Thanks for improving the doc! Are you moving this to be used in canonicalization next?
I think a first good step would be to make it a pattern and test it with a pass that applies it in the greedy rewriter. I would land this first and then try to enable this in the canonicalized.

Also, have you thought already about how to get rid of string manipulation?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124750/new/

https://reviews.llvm.org/D124750



More information about the cfe-commits mailing list