[PATCH] D125228: [clangd] Support for standard inlayHint protocol

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:586
 
+  // Only advertise inlayHints extension if client doesn't support the standard
+  // implementation.
----------------
sammccall wrote:
> I still feel a little uncomfortable with this because it cuts against the design of capabilities, and it's not clear what concrete problem it solves.
> 
> Most likely it won't cause nor solve any problems. But it might lead to a lot of confusion.
> (e.g. in nvim and some others, base capabilities are provided but  customized by extensions/users. If one extension sets the standard capability and another tries to use clangd hints, or the user sets the wrong capability at first out of confusion, it seems hard to debug)
> 
> However it's up to you, I promise this is my last comment about it :-)
> because it cuts against the design of capabilities

agreed, i thought this was more of a capability when i was proposing it. but noticed that it wasn't while going into the details and rubbed me the wrong way as well. so dropping it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125228/new/

https://reviews.llvm.org/D125228