[PATCH] D125312: [pseudo] benchmark cleanups. NFC

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 10 06:46:06 PDT 2022


sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added a project: All.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, alextsao1999.
Herald added a project: clang-tools-extra.

- add missing benchmark for lex/preprocess steps
- name benchmarks after the function they're benchmarking, when appropriate
- remove unergonomic "run" prefixes from benchmark names
- give a useful error message if --grammar or --source are missing
- Use realistic example of how to run, run all benchmarks by default. (for someone who doesn't know the commands, this is the most useful action)
- Improve typos/wording in comment
- clean up unused vars
- avoid "parseable stream" name, which isn't a great name & not one I expected to escape from ClangPseudoMain


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D125312

Files:
  clang-tools-extra/pseudo/benchmarks/Benchmark.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D125312.428357.patch
Type: text/x-patch
Size: 5391 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220510/4771b6b4/attachment-0001.bin>


More information about the cfe-commits mailing list