[PATCH] D125259: [C11] Diagnose unreachable generic selection associations

[Erich Keane via Phabricator via cfe-commits]

erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.

One minor preference, otherwise LGTM.



================
Comment at: clang/lib/Sema/SemaExpr.cpp:1702
+
+          if (Reason)
+            Diag(Types[i]->getTypeLoc().getBeginLoc(),
----------------
Splitting this up into the separate line for only 2 items seems like a waste, would it look better to just do the diag in each 'if'?  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125259/new/

https://reviews.llvm.org/D125259