[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

Richard via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 9 08:29:45 PDT 2022


LegalizeAdulthood added inline comments.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize-macro-to-enum.rst:21-22
+  `,`, `-`, `+`, `*`, `/`, `%`, `&`, `|`, `^`, `<`, `>`, `<=`, `>=`,
+  `==`, `!=`, `||`, `&&`, `<<`, `>>` or `<=>`, and the ternary operator
+  `?:`.  Parenthesized expressions are also recognized.  This
+  recognizes the most valid expressions.  In particular, expressions
----------------
aaron.ballman wrote:
> Maybe we should also list the binary `?:` GNU extension and comma expressions?
Yes, I need to update the docs on that and also call out the potential false positives explicitly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124500/new/

https://reviews.llvm.org/D124500



More information about the cfe-commits mailing list