[PATCH] D125180: [Frontend] when attaching a preamble, don't generate the long predefines buffer.

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 9 05:54:22 PDT 2022


kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:769
+  // So don't bother generating the long version of the predefines buffer.
+  // The is going to overwrite it anyway (to almost nothing).
+  PreprocessorOpts.UsePredefines = false;
----------------
s/The/Preamble

> to almost nothing

This feels like too much of a detail, i'd probably drop. up to you though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125180/new/

https://reviews.llvm.org/D125180



More information about the cfe-commits mailing list