[clang-tools-extra] bb53eb1 - [clangd] Skip extra round-trip in parsing args in debug builds. NFC

[Sam McCall via cfe-commits]

Author: Sam McCall
Date: 2022-05-09T14:45:35+02:00
New Revision: bb53eb1ef4369fa7ae13d693eb219665c2cecd24

URL: https://github.com/llvm/llvm-project/commit/bb53eb1ef4369fa7ae13d693eb219665c2cecd24
DIFF: https://github.com/llvm/llvm-project/commit/bb53eb1ef4369fa7ae13d693eb219665c2cecd24.diff

LOG: [clangd] Skip extra round-trip in parsing args in debug builds. NFC

This is a clever cross-cutting sanity test for clang's arg parsing I suppose.
But clangd creates thousands of invocations, ~all with identical trivial
arguments, and problems with these would be caught by clang's tests.
This overhead accounts for 10% of total unittest time!

Differential Revision: https://reviews.llvm.org/D125169

Added: 
    

Modified: 
    clang-tools-extra/clangd/Compiler.cpp

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/clangd/Compiler.cpp b/clang-tools-extra/clangd/Compiler.cpp
index 2cf2eb8cda14..04ec04514eb9 100644
--- a/clang-tools-extra/clangd/Compiler.cpp
+++ b/clang-tools-extra/clangd/Compiler.cpp
@@ -85,10 +85,16 @@ void disableUnsupportedOptions(CompilerInvocation &CI) {
 std::unique_ptr<CompilerInvocation>
 buildCompilerInvocation(const ParseInputs &Inputs, clang::DiagnosticConsumer &D,
                         std::vector<std::string> *CC1Args) {
-  if (Inputs.CompileCommand.CommandLine.empty())
+  llvm::ArrayRef<std::string> Argv = Inputs.CompileCommand.CommandLine;
+  if (Argv.empty())
     return nullptr;
   std::vector<const char *> ArgStrs;
-  for (const auto &S : Inputs.CompileCommand.CommandLine)
+  ArgStrs.reserve(Argv.size() + 1);
+  // In asserts builds, CompilerInvocation redundantly reads/parses cc1 args as
+  // a sanity test. This is not useful to clangd, and costs 10% of test time.
+  // To avoid mismatches between assert/production builds, disable it always.
+  ArgStrs = {Argv.front().c_str(), "-Xclang", "-no-round-trip-args"};
+  for (const auto &S : Argv.drop_front())
     ArgStrs.push_back(S.c_str());
 
   CreateInvocationOptions CIOpts;