[PATCH] D124874: [clang] add -fmodule-file-home-is-cwd

Nathan Sidwell via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 9 05:35:46 PDT 2022


urnathan added inline comments.


================
Comment at: clang/lib/Serialization/ASTWriter.cpp:1231-1236
+    SmallString<128> BaseDir(CWD->getName());
+    cleanPathForOutput(Context.getSourceManager().getFileManager(), BaseDir);
+    BaseDirectory.assign(BaseDir.begin(), BaseDir.end());
+  } else if (WritingModule && WritingModule->Directory) {
     SmallString<128> BaseDir(WritingModule->Directory->getName());
     cleanPathForOutput(Context.getSourceManager().getFileManager(), BaseDir);
----------------
This looks unfortunately duplicatey.  Any less-worse way of avoiding that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124874/new/

https://reviews.llvm.org/D124874



More information about the cfe-commits mailing list