[PATCH] D124658: [analyzer] Canonicalize SymIntExpr so the RHS is positive when possible

[Balázs Benics via Phabricator via cfe-commits]

steakhal added a comment.

In D124658#3499883 <https://reviews.llvm.org/D124658#3499883>, @tomasz-kaminski-sonarsource wrote:

> Updated patch to match master after revert.

It's still messed up. Please double-check.



================
Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:117
+    return resultType.isUnsigned();
+  } else {
+    // If resultType bitWith is higher that number of bits required
----------------
`else` after `return` is unnecessary.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124658/new/

https://reviews.llvm.org/D124658