[PATCH] D124977: [NFC][Clang] Modify expect of fail test or XFAIL because CSKY align is different

Zixuan Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 6 19:29:41 PDT 2022


zixuan-wu added inline comments.


================
Comment at: clang/test/Sema/builtin-alloca-with-align.c:32
 void test8(void) {
+#if defined(__csky__)
   __builtin_alloca_with_align(sizeof(__INT64_TYPE__), __alignof__(__INT64_TYPE__)); // expected-warning {{second argument to __builtin_alloca_with_align is supposed to be in bits}}
----------------
rengolin wrote:
> This test is platform agnostic, perhaps the extra error could be in a new test, exclusively for csky?
Then I prefer to split the file and add UNSUPPORTED for CSKY in the other file which only contains test8


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124977/new/

https://reviews.llvm.org/D124977



More information about the cfe-commits mailing list