[PATCH] D124966: Thread safety analysis: Handle compound assignment and ->* overloads

Aaron Puchert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 6 14:27:00 PDT 2022


aaronpuchert added a comment.

In D124966#3497305 <https://reviews.llvm.org/D124966#3497305>, @aaron.ballman wrote:

> LGTM! You should probably add a release note for this change so users know about it.

Good point, I'll add a note about compound assignment and increment/decrement. I'll leave out `operator->*` though if you don't mind because it's rarely overloaded.

> Do we need to update any documentation from this?

I don't think so, we don't really specify what we consider as write and what not. It's more of a heuristic anyway, unless at some point we feel comfortable enough to do D52395 <https://reviews.llvm.org/D52395>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124966/new/

https://reviews.llvm.org/D124966



More information about the cfe-commits mailing list