[PATCH] D123784: [clang][analyzer][ctu] Traverse the ctu CallEnter nodes in reverse order
Gabor Marton via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri May 6 13:48:44 PDT 2022
martong marked an inline comment as done.
martong added inline comments.
================
Comment at: clang/lib/StaticAnalyzer/Core/WorkList.cpp:216-218
// Number of inserted nodes, used to emulate DFS ordering in the priority
// queue when insertions are equal.
+ long Counter = 0;
----------------
steakhal wrote:
> It seems like you are not exploiting the signedness of this variable. And a counter should never be negative anyway.
It is used in the descendant class.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123784/new/
https://reviews.llvm.org/D123784
More information about the cfe-commits
mailing list