[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 6 12:15:21 PDT 2022


tra added inline comments.


================
Comment at: clang/lib/CodeGen/CGCUDARuntime.h:56-70
+    enum OffloadRegionEntryKindFlag : uint32_t {
+      /// Mark the region entry as a kernel.
+      OffloadRegionKernelEntry = 0x0,
+    };
+
+    /// The kind flag of the global variable entry.
+    enum OffloadVarEntryKindFlag : uint32_t {
----------------
We can also fold both enums into one, as we still have the ambiguity of what `flags=0` means. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123471/new/

https://reviews.llvm.org/D123471



More information about the cfe-commits mailing list