[PATCH] D124613: In MSVC compatibility mode, friend function declarations behave as function declarations

Fri May 6 07:59:36 PDT 2022

thakis added a comment.

Thanks for the patch!

Two comments, more specific, one general:

1. This broke compilation of (at least) one TU in chromium, see https://bugs.chromium.org/p/chromium/issues/detail?id=1323014#c5 . Can you look into if that's expected? (We've worked around this for now.)

2. We try to add workarounds like this only if it's necessary for system headers, and in cases when it is necessary we do want to emit some `-Wmicrosoft` warning so that user code has a chance to stay compliant. This old presentation talks about this some: https://docs.google.com/presentation/d/1oxNHaVjA9Gn_rTzX6HIpJHP7nXRua_0URXxxJ3oYRq0/edit#slide=id.g71ecd450e_2_812

What was the motivation for this change? Given we haven't needed this for such a long time, chances are it's not for system headers (?)

If we do need this, please add a warning that fires when this extension is required. Otherwise, it'd be good if we could undo this.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124613/new/

https://reviews.llvm.org/D124613