[PATCH] D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals

[Timm Bäder via Phabricator via cfe-commits]

tbaeder added inline comments.


================
Comment at: clang/test/Lexer/utf8-char-literal.cpp:39
+#  if defined(CHAR8_T)
+#    if u8'\xff' == '\xff' // expected-warning {{right side of operator converted from negative value to unsigned}}
+#      error Something's not right.
----------------
I'm a little confused with the amount of combinations at this point, so please tell me if the emitted warning here looks wrong.


================
Comment at: clang/test/Lexer/utf8-char-literal.cpp:70
+#  endif
+#endif
----------------
I know indenting the preprocessor directives here isn't according to coding style, but it helps a lot with readability.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124996/new/

https://reviews.llvm.org/D124996