[PATCH] D123676: [clang-format] Fix WhitespaceSensitiveMacros not being honoured when macro closing parenthesis is followed by a newline.

Marek Kurdej via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 6 01:58:53 PDT 2022


curdeius marked 5 inline comments as done.
curdeius added inline comments.


================
Comment at: clang/unittests/Format/FormatTest.cpp:23545
+  // Newlines are important here.
+  EXPECT_EQ("FOO(1+2  );\n", format("FOO(1+2  );\n", Style));
+  EXPECT_EQ("FOO(1+2  )\n", format("FOO(1+2  )\n", Style));
----------------
curdeius wrote:
> owenpan wrote:
> > Do we really need this test case?
> Not really. I just wrote it to cover both cases but it's covered by existing cases indeed. Will remove.
On a second thought, we don't have any other test with a semicolon and a newline, so I'd rather keep this test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123676/new/

https://reviews.llvm.org/D123676



More information about the cfe-commits mailing list