[PATCH] D125061: [clang] A more robust way to attach comments

[Zixu Wang via Phabricator via cfe-commits]

zixuw added a comment.

Well, apparently there are still some corner-case bugs in the logic. ExtractAPI and a few other tests failed. Will look into it tomorrow.

And if folks have concerns or opinions of the performance/space cost of adding the extra pointer to `DeclBase`, I can try to keep the original logic and just special-case enum constants to find the previous enum constant decl in the parent enum. Not sure if there are existing ways to get preceding enum constants efficiently, otherwise it'd be an O(n^2) operation for an enum.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125061/new/

https://reviews.llvm.org/D125061