[PATCH] D125050: [OpenMP] Try to Infer target triples using the offloading architecture

Joseph Huber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 5 16:49:47 PDT 2022


jhuber6 marked 3 inline comments as done.
jhuber6 added inline comments.


================
Comment at: clang/lib/Driver/Driver.cpp:788-789
+                               options::OPT_fno_openmp, false) &&
+      (C.getInputArgs().hasArg(options::OPT_fopenmp_targets_EQ) ||
+       C.getInputArgs().hasArg(options::OPT_offload_arch_EQ));
+  if (IsOpenMP) {
----------------
tra wrote:
> So, specifying just `-fopenmp` will result in `IsOpenMP=false`? This seems odd.
> Perhaps the variable should be called `IsOpenMPOffload` ? 
Will do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125050/new/

https://reviews.llvm.org/D125050



More information about the cfe-commits mailing list