[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

Cassie Jones via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 5 10:54:48 PDT 2022


porglezomp added a comment.

I would be interested in adding some kind of test for this, but am not sure how.

I think the robust general-purpose check here would be to ensure that no file is referring to symbols defined by the various `config.h` etc. files without including those files, but am not sure how to do that analysis, or if it's feasible with legacy code. That's obviously a much larger thing to test than this one change, and might run into problems if there are any define flags that don't come from the CMake config.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124974/new/

https://reviews.llvm.org/D124974



More information about the cfe-commits mailing list