[PATCH] D125026: [clang-tidy][NFC] Reimplement most of SimplifyBooleanExpr with RecursiveASTVisitors

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 5 10:53:40 PDT 2022


njames93 created this revision.
njames93 added reviewers: alexfh, klimek, aaron.ballman.
Herald added subscribers: carlosgalvezp, xazax.hun.
Herald added a project: All.
njames93 requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.

Reimplement most of the matching logic using Visitors instead of matchers.

Benchmarks from running the check over SemaCodeComplete.cpp
Before 1.02s, After 0.87s


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D125026

Files:
  clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp
  clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D125026.427388.patch
Type: text/x-patch
Size: 38007 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220505/543343fb/attachment-0001.bin>


More information about the cfe-commits mailing list