[clang] ad2263d - [Sema] Replace invalid FIXME about memory leak. NFC

Ilya Biryukov via cfe-commits cfe-commits at lists.llvm.org
Thu May 5 08:08:59 PDT 2022


Author: Ilya Biryukov
Date: 2022-05-05T15:04:11Z
New Revision: ad2263de9f75119626f316e253fdc1de28d5c23a

URL: https://github.com/llvm/llvm-project/commit/ad2263de9f75119626f316e253fdc1de28d5c23a
DIFF: https://github.com/llvm/llvm-project/commit/ad2263de9f75119626f316e253fdc1de28d5c23a.diff

LOG: [Sema] Replace invalid FIXME about memory leak. NFC

Added in my previous patch by mistake.

Added: 
    

Modified: 
    clang/lib/Sema/SemaConcept.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/Sema/SemaConcept.cpp b/clang/lib/Sema/SemaConcept.cpp
index 4ec37a94089b0..261f57e4d185b 100644
--- a/clang/lib/Sema/SemaConcept.cpp
+++ b/clang/lib/Sema/SemaConcept.cpp
@@ -341,7 +341,7 @@ bool Sema::CheckConstraintSatisfaction(
   OutSatisfaction = *Satisfaction;
   // We cannot use InsertPos here because CheckConstraintSatisfaction might have
   // invalidated it.
-  // FIXME: this leaks memory, we should allocate in the arena instead.
+  // Note that entries of SatisfactionCache are deleted in Sema's destructor.
   SatisfactionCache.InsertNode(Satisfaction.release());
   return false;
 }


        


More information about the cfe-commits mailing list