[PATCH] D124447: [clang-tidy] Add infrastructure support for running on project-level information

Thu May 5 07:52:28 PDT 2022

whisperity added a comment.

In D124447#3493446 <https://reviews.llvm.org/D124447#3493446>, @aaron.ballman wrote:

> precommit CI is showing a fair amount of failures that I believe are related to your patch.

It was me who helped @bahramib to rebase and split a much larger and more convoluted development history into broken up patches for review, and I have no idea what is causing the CI issues, because all the CI issues are related to unit test libraries removing `const` from fixits and such(??) which this patch (or any in the current patch set) doesn't even touch, at all. I did run the test targets locally... it's likely that simply the rebase and the push happened against an unclean/breaking main branch...

We can investigate later, but I think the review can be done either way. If something is related, it has to be tangential, we strived to make the entire new infrastructure fully backwards compatible.

The only reason I can think of is that some `LangOpts` might not be forwarded correctly somewhere, will definitely look into this.

(Also, full disclosure, I am the B.Sc. thesis supervisor of @bahramib so I'm only here to keep an eye on (and fix up the "very LLVM-y" parts) of the check, I cannot impartially review and accept this as I was involved in the full creation process. 😇)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124447/new/

https://reviews.llvm.org/D124447