[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added a comment.

I agree that clangd's indexing should probably be higher priority than whatever FS indexing is going on (because clangd's indexing only start when user actually starts working on a project, hence this indicates some level of "interactiveness"). so I feel like the right default is Utility, rather than Background.
But we had this behavior for a long while and people didn't complain up until M1s. So this is definitely going to result in some behavior change for intel users, even if we agree on this is making the state better for M1s.
Unfortunately I am not in a position to say what does the Utility vs Background imply for intel chips for sure, to tell the behavior change isn't going to be a regression. If this renders next clangd unusable by intel mac folks, it would be really unfortunate.

So I am also in favor of keeping the Background and switch the default in clangd to Low, while providing a flag to turn this back into Background. Hopefully we can retire the flag in between.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124715/new/

https://reviews.llvm.org/D124715