[PATCH] D124966: Thread safety analysis: Handle compound assignment and ->* overloads
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu May 5 04:19:47 PDT 2022
aaron.ballman added inline comments.
================
Comment at: clang/lib/Analysis/ThreadSafety.cpp:1994
+ case OO_Equal:
+ case OO_PlusEqual:
+ case OO_MinusEqual:
----------------
If we're going to be handling these, should we also be handling overloads of `++` and `--`?
================
Comment at: clang/test/SemaCXX/warn-thread-safety-analysis.cpp:4344
+ Data& operator+=(int);
+
----------------
We should probably add test coverage for all the newly supported operators.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124966/new/
https://reviews.llvm.org/D124966
More information about the cfe-commits
mailing list